feat(openai): support deferred resolution for configured MCP connectors - #933
Open
mkoushni wants to merge 11 commits into
Open
feat(openai): support deferred resolution for configured MCP connectors#933mkoushni wants to merge 11 commits into
mkoushni wants to merge 11 commits into
Conversation
|
Missing Signed-off-by: 8998839. All commits require sign-off (via |
Praxis connector_id values are pipeline-local, so deferred MCP entries are resolved in-memory, stripped from the backend body, and listed only after a tool_search_call instead of forwarding internal IDs to inference. Signed-off-by: mkoushni <mkoushni@redhat.com>
mkoushni
force-pushed
the
feat/703-deferred-mcp-connectors
branch
from
September 6, 2026 15:43
8998839 to
c3779ff
Compare
Keep deferred MCP connector coverage alongside main's streaming IRR tests. Signed-off-by: mkoushni <mkoushni@redhat.com>
|
Watch the flyover → · 10:58 · 6 chapters · 14 files An animated walkthrough of this diff: context, the problem, the change, implementation care, code walkthrough, and impact. b118dcd · updated automatically by flyovers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Praxis
connector_idvalues are pipeline-local. Acceptingdefer_loading: truewithout an ownership model would have forwarded those IDs to the inference backend.openai_mcp_tool_resolveaccepts deferred configured connectors when the request includestool_search, injects the configured URL in-memory only, skips eagertools/list, and rewrites the backend body to a sanitizedtype: mcpstub (noconnector_id, URL, authorization, or headers).openai_agentic_loopextractstool_search_callinto request state (not backendmessages).openai_mcp_dispatchloads every pending deferred connector ontool_search_call, then dispatches through the existingtools/callpath.max_rewritten_body_byteschecks before mutatingmcp_tool_mapor output. Failures restore pending connectors.connector_id+server_urlstill 400 before outbound activity. Eager connectors and directserver_urlare unchanged.The first inference round still sends the sanitized
type: mcpstub plustool_search; the backend must accept those OpenAI hosted-tool shapes. Anytool_search_callloads every pending deferred connector.Closes #703
Validation
cargo test -p praxis-ai-apis --lib -- openai_mcp_tool_resolve agentic_loop mcp_dispatch(316 passed)cargo test -p praxis-tests-integration --test suite -- deferred_connector mixed_eager(5 passed)cargo clippy -p praxis-ai-apis --all-targets -- -D warningsmake lintChecklist
Signed-off-bytrailer.Breaking changes
None. Deferred
connector_idwas previously rejected; it is now accepted only withtool_searchand an agentic MCP dispatch loop.